feat: use CSS color-scheme to improve dark theme#2007
Open
ayhid wants to merge 2 commits intostrapi:mainfrom
Open
feat: use CSS color-scheme to improve dark theme#2007ayhid wants to merge 2 commits intostrapi:mainfrom
ayhid wants to merge 2 commits intostrapi:mainfrom
Conversation
Add the color-scheme CSS property to the html element based on the active theme. This makes native browser UI elements (scrollbars, form controls, selection highlights) render in the appropriate color scheme. Closes strapi#947
|
@ayhid is attempting to deploy a commit to the Strapi Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: fd9b3e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
color-schemeproperty to thehtmlelement, driven by the active themeCOLOR_SCHEMESconst map andColorSchemetype to avoid magic stringscolorScheme: 'light'onlightThemeandcolorScheme: 'dark'ondarkThemeCloses #947
Test plan